What makes us excited when coding? Refactoring the code, involving new technology, or using a fantastic solution to resolve a hard problem?

These things are harder and can prove our ability. But we should not forget all team members will maintain them, not only us.

If our team is pretty stable and all the team members are senior developers, there is nothing to be concerned about.

But what if it is not true? how do we ensure the team can still maintain the code very well?

Unfortunately, this is my team’s situation. My team already worked on Scala for more than 5 years, we use Functional Programming in Scala heavily and would like to try any new technologies. But with more and more fantastic work we did, we found it’s harder and harder to continue the business, finally we decide to write junior code in Scala.

In this post, I will share the reason for the decision and show you how to write junior code in Scala.

Why Junior Code?

Recruitment

We tried to hire people with our required techniques, such as Functional Programming in Scala, Cats, Fs2, http4s, circe, doobie, eff, etc. But it’s harder than we thought.

In the past 5 years, we got 18 new team members, only 2 of them have Spark experience.

Most of the new team members are from other tech stacks, for example, Java, JavaScript, or Ruby.

So we have to train our new team members.

Training

Considering most new team members don’t have Scala experience, the purpose of training is to help them to be senior Scala developers.

Why senior Scala developer? Because we used lots of advanced libraries, such as eff, Fs2, etc, and there are different architectures in different systems, such as Cake pattern, ReaderT pattern, Tagless Final, etc. Our team members have to master all the advanced knowledge to maintain the existing systems.

Did I mention the training time? Ideally, it should only take a few weeks to train new team members, then they can contribute qualified code. But could you become a senior Java developer from graduate in a few weeks? The answer is definitely no, no matter how good is the training, The brain needs time to understand the knowledge, that’s the problem.

We prepared more than 20 hours of sessions and workshops, which cover the knowledge from Functional Programming in Scala to advanced library usage.

According to the feedback of new team members, we can divide the knowledge into two parts

  1. Junior knowledge, which can be mastered in a few weeks.

    • Scala language
    • Functional Programming fundamental concept
    • Simple Monad, like Option, Either, IO
    • Simple high-order functions, like map, flatMap, filter, reduce, foldLeft
    • Library with a simple interface, like Cats, http4s, circe, doobie

  2. Senior knowledge, which needs several months to understand.

    • Implicit
    • Free Monad
    • Complicated Monad, like Reader, State
    • Monad Transformer, like ReaderT, WriterT, StateT
    • Complicated high-order functions, like traverse and sequence
    • Library with a complicated interface, like eff, Fs2
    • Architecture, like Cake pattern, ReaderT pattern, Tagless Final

We used lots of Senior knowledge in our systems, which means our training can not help our new team members to understand and maintain the existing systems quickly.

Possible Solutions

There are 3 possible solutions

  1. We can bless one day there are enough developers with our required skills, then we don’t need to worry about the business anymore. But we know it’s impossible if we do nothing.

  2. We can switch to other languages, like TypeScript or Java. But there are more than 50 existing systems written by Scala and most of our senior developers like Functional Programming in Scala. If we switch languages, we need to spend huge effort to rewrite the systems and most of the senior developers may run. This is what we can’t afford.

  3. Write junior code, it only needs the Junior knowledge, then it will be easier for both new team members and existing members, we can not only utilize the benefit of Functional Programming in Scala but also save the effort of training.

Option 3 is a good balance between technical excellence and business continuation.

How to write junior code in Scala?

Avoid implicit

implicit is a powerful tool, but it is very easy to be abused.

Most of the time, it is implicit which makes the code hard to read and maintain. It’s also the biggest blocker for new team members to learn Scala.

For example

import IntInstances._

val a:Int = "1"
if(a.isGreaterThan(0)){
  println("The number is greater than 0")
}

Could you understand this code? Why an Int variable can accept a String value? Where does the function isGreaterThan come from?

How about this one

def toInt(String str):Int = a.toInt
def isGreaterThan(Int x, Int y):Boolean = x > y

val a:Int = toInt("1")
if(isGreaterThan(a, 0)){
  println("The number is greater than 0")
}

This one is not fancy, but most developers can understand it.

implicit is not a required technique to write better code. Unless the library requires implicit instances or we’re pretty sure what we are doing, let’s not use it.

Unified Monadic Return Type

The monadic return type of function is very important in Functional Programming, it should be able to handle all the side-effects.

For example, if a function may return a null value, we can return Option. If a function may return an error, we can return Either. If a function may interact with API or database, we can return IO or Task.

What if we have two functions with different monadic return types? for example

def last(list: List[String]):Option[String] = ???
def toInt(x:String):Either[String, Int] = ???

If we want to compose these two functions, we need to convert Option to Either

for{
  x <- last(List("1")).toRight("The list is empty")
  value <- toInt(x)
} yield value

To avoid the conversion among different monadic return types, we can use a unified monadic return type in the whole project, then all the functions can be composed directly.

But we need to choose the monadic return type carefully

  1. It should be powerful enough to handle all potential side-effects. for example, we can not use Either if we need to interact with API or database. IO and Task are good candidates.
  2. Its interface should be easy to use. for example, Free Monad and ReaderT are too complicated, we need more time to understand them.

OO architecture with pure functions

We tried lots of architectures in our projects.

At the beginning we used Cake pattern,

trait Application  { self: Service1 with Service2 with Service3 => 
  def run = ???
} 

val application = new Application with Service1Implementation with Service2Implementation with Service3Implementation {}

application.run

then moved to eff which supports extensible effects,


trait ApplicationEffect[A]

case object Start extends ApplicationEffect[Nothing]

type Stack = Fx.fx5[ApplicationEffect, Service1Effect, Service2Effect, Service3Effect, IO]

implicit class Service1InterpretationOps[R, A](eff: Eff[R, A]) {
  def runService1[U: Member.Aux[Service1Effect, R, ?]: HasIO, A](): Eff[U, A] = ???
}

implicit class Service2InterpretationOps[R, A](eff: Eff[R, A]) {
  def runService2[U: Member.Aux[Service2Effect, R, ?]: HasIO, A](): Eff[U, A] = ???
}

implicit class Service3InterpretationOps[R, A](eff: Eff[R, A]) {
  def runService3[U: Member.Aux[Service3Effect, R, ?]: HasIO, A](): Eff[U, A] = ???
}

implicit class ApplicationInterpretationOps[R, A](eff: Eff[R, A]) {
  def runApplication[U: Member.Aux[ApplicationEffect, R, ?]: HasService1Effect: HasService2Effect: HasService3Effect, A](): Eff[U, A] = ???
}

val application = Eff.send[Stack](Start).runApplication().runService1().runService2().runService3()

application.unsafeRunSync()

and after two years we embrace Tagless Final,

trait Application[M[_]] {
  def run:M[Unit] = ???
}

class ApplicationImplementation[M[_]:Monad](service1: Service1[M], service2: Service2[M], service3: Service3[M]){
  def run:M[Unit] = ???
}

val application = new ApplicationImplementation[IO](new Service1Implementation[IO](), new Service2Implementation[IO](), new Service3Implementation[IO]())

application.run.unsafeRunSync()

then we come back to traditional OO architecture with pure functions.


trait Application {
  def run:IO[Unit] = ???
}

class ApplicationImplementation(service1: Service1, service2: Service2, service3: Service3){
  def run:IO[Unit] = ???
}

val application = new ApplicationImplementation(new Service1Implementation(), new Service2Implementation(), new Service3Implementation())

application.run.unsafeRunSync()

The last one is pretty easy to understand for non-Scala developers, the only thing they need to learn is how to use IO.

For eff architecture, we even spend 3 months decommissioning it from all related projects, because it’s hard to understand, and after some senior team members left, only a few people can understand and maintain it.

Most developers are familiar with OO architectures, they just need to focus on how to make the function pure. And we just use the OO architecture to group the pure functions, there is no mutable property in it, all the data are immutable.

In this way, we can not only utilize the advantage of Functional Programming but also make our new team members happy.

Move senior code to a library

We still need the senior code, because there are always complicated problems, such as NewRellic integration, log with transaction id, global context, etc. Sometimes there is no mature library in Scala to solve them, then we need to build our library.

There is only one rule for the library, the interface should be easy to use. Apart from that, we can do what we want to do, even involve side-effects.

For example, if we want to print a log with a transaction id, we may need to use MDC to store the transaction id of each thread, which is a side-effect. But if there is no other better solution and the library can be tested very well, we can just adopt the side-effect.

We’d better open-source the library, the same problem may be also happening in other teams.

In this way, we can contribute to the ecosystem and make our senior team members happy.

Summary

This is the lesson we learned in Scala, it also happened in some Haskell teams. We always need to balance business continuation and technical excellence to achieve success as one team.

Comments

You May Also Enjoy